-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-5792: multi-chain wallet_sendCalls #8771
Conversation
✅ All reviewers have approved. |
* MUST send the calls on the same chain identified by the request's `chainId` property | ||
* MUST send the calls in the order specified in the request | ||
* MUST send the calls on the same chain identified by the call's `chainId` property | ||
* MUST NOT await for any calls to be finalized to complete the batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why you think we should enforce this? I'd expect this to be up to the wallet, until we have the other capability we talked about which would enforce waiting for calls to be mined across chains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that we would enforce the behavior to always be "parallel" by default
So the new capability would be "sequential" if available
But my take is that either way it should be deterministic by the spec rather than wallet-dependent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm just seeing this. I do feel like generally order matters to devs, but trying to sequence multi chain calls is probably too difficult. Too hard to know when the output of one will land on the other chain, if I am, say, funding my account on chain A from chain B
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
Changes proposed:
chainId
from top-level to call-levelatomicBatch
regarding multi-chain